netdev - Re: Deadlock after info soft-safe -> soft-unsafe lock order detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1LKXMF-0006fe-DK@gondolin.me.apana.org.au>
Date:	Wed, 07 Jan 2009 23:17:59 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	akpm@...ux-foundation.org (Andrew Morton)
Cc:	zdenek.kabelac@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, dada1@...mosbay.com
Subject: Re: Deadlock after info soft-safe -> soft-unsafe lock order detected

Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> I'd be suspecting the percpu counter work in TCP?

This is the bogus lockdep output which is fixed by

commit ea319518ba3de282c13ae1cf4bf2215c5e03e67e
Author: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Date:   Fri Dec 26 15:08:55 2008 +0100

    locking, percpu counters: introduce separate lock classes
    
    Impact: fix lockdep false positives
    
    Classify percpu_counter instances similar to regular lock objects --
    that is, per instantiation site.
    
    The networking code has increased its use of percpu_counters, which
    leads to false positives if they are treated as a single class.
    
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

It was only pulled very recently despite the Dec 26 date.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html