netdev - Re: Data corruption issue with splice() on 2.6.27.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090107132258.GE9677@ff.dom.local>
Date:	Wed, 7 Jan 2009 13:22:58 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Willy Tarreau <w@....eu>
Cc:	Evgeniy Polyakov <zbr@...emap.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Data corruption issue with splice() on 2.6.27.10

On Wed, Jan 07, 2009 at 02:15:39PM +0100, Willy Tarreau wrote:
> On Wed, Jan 07, 2009 at 01:10:57PM +0000, Jarek Poplawski wrote:
> > On Wed, Jan 07, 2009 at 04:02:59PM +0300, Evgeniy Polyakov wrote:
> > ...
> > > If I understood correctly Jarek's patch, he wants to allocate a page and
> > > copy linear content of the skb there, so this will end up being the same
> > > case as with splicing from the file. And while generally this may be a
> > > good idea, but with usual 1.5k mtu this will copy every skb, which is
> > > rather bad idea. Will have to think :)
> > > 
> > 
> > As I mentioned earlier, I (poorly) tried to realize Changli's idea
> > only, and it's more to verify the reason still (after it failed with
> > SG method...).
> 
> Jarek, since it now works when disabling both SG and GSO, we know that the
> bug is triggered when passing through do_tcp_sendpage(). Thus, I will not
> try your patch #3 yet, but rather wait for fix candidates to try.

Sure! Congratulations for debugging to you and Evgeniy!

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html