netdev - Re: [PATCH] virtio_net: add link status handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231352283.5050.76.camel@localhost.localdomain>
Date:	Wed, 07 Jan 2009 18:18:03 +0000
From:	Mark McLoughlin <markmc@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Anthony Liguori <anthony@...emonkey.ws>,
	netdev <netdev@...r.kernel.org>, kvm <kvm@...r.kernel.org>
Subject: Re: [PATCH] virtio_net: add link status handling

Hi Rusty,

On Fri, 2008-12-12 at 18:34 +1030, Rusty Russell wrote:
> On Thursday 11 December 2008 05:04:44 Mark McLoughlin wrote:
> > On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote:
> > > Rusty Russell wrote:
> > > > On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote:    
> > > >> It would be nice if the virtio-net card wrote some acknowledgement that 
> > > >> it has received the link status down/up events.
> > > >
> > > > How about of every status change event? ie. a generic virtio_pci solution?
> > > 
> > > A really simple way to do it would just be to have another status field 
> > > that was the guest's status (verses the host requested status which the 
> > > current field is).  All config reads/writes result in exits so it's easy 
> > > to track.
> > > 
> > > Adding YA virtio event may be a little overkill.
> > 
> > Sounds very reasonable; that and Rusty's "mask out unknown bits"
> > suggestion in the version below.
> 
> Not quite what I was after.  I've taken the original patch, added the
> masking change.  I'll test here and feed to DaveM.

This never got pushed to davem, did it? What you've got in your queue
looks fine to me ...

Cheers,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html