netdev - Re: [PATCH 0/2][RFC] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231352906.7109.140.camel@lappy>
Date:	Wed, 07 Jan 2009 11:28:25 -0700
From:	Alex Williamson <alex.williamson@...com>
To:	Anthony Liguori <anthony@...emonkey.ws>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, kvm <kvm@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	Mark McLoughlin <markmc@...hat.com>
Subject: Re: [PATCH 0/2][RFC] virtio_net: MAC filtering

On Wed, 2009-01-07 at 12:14 -0600, Anthony Liguori wrote:
> Alex Williamson wrote:
> >
> > As noted in the RFC thread adding the kvm/qemu backing, this does
> > increase the size of the virtio-net device I/O port space, up to 1kB
> > with PCI rounding if we add a 4k entry VLAN bitmap.  A 64 device limit
> > is still pretty high for a VM, but maybe we should think about adding
> > MMIO space for virtio-pci.  Thanks,
> >   
> 
> I'm not quite sure the best way to address this.  Maybe another control 
> queue for sending commands to control this sort of stuff?  What are your 
> thoughts Rusty?

This is also a good time to decide if a fixed 16 entry MAC filter table
is sufficient.  Should the size be programmed into the config space?
There's plenty of room to make it a bigger fixed size and still stay at
1kB of I/O port space with the VLAN table.  This implementation is a
little wasteful of space in using 8 bytes to store the MAC and a valid
bit, but I suspect there's some endian issues I'm ignoring and a
standard data type might make that easier later.

Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html