netdev - Re: [PATCH] dm9601: warn on invalid mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874p0bmsl0.fsf@macbook.be.48ers.dk>
Date:	Wed, 07 Jan 2009 09:24:43 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Wu Fengguang <wfg@...ux.intel.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] dm9601: warn on invalid mac address

>>>>> "Wu" == Wu Fengguang <wfg@...ux.intel.com> writes:

Hi,

 >> Also, it seems like you're not writing the random address to the
 >> hardware registers, so you won't be able to receive any unicast -
 >> You'll need to add a call to dm9601_set_mac_address() or similar.

 Wu> Good catch. I had wanted to ask why it only works with promisc
 Wu> mode ;-)

;)

 Wu> Here is the tested patch.

 Wu> Thanks,
 Wu> Fengguang
 Wu> ---
 Wu> dm9601: tell HW about random generated mac address

 Wu> Otherwise unicast RX will only work in promisc mode.

 Wu> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
 Wu> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>

Acked-by: Peter Korsgaard <jacmet@...site.dk>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html