netdev - Re: Data corruption issue with splice() on 2.6.27.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090107095415.GB30749@1wt.eu>
Date:	Wed, 7 Jan 2009 10:54:15 +0100
From:	Willy Tarreau <w@....eu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Evgeniy Polyakov <zbr@...emap.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Data corruption issue with splice() on 2.6.27.10

On Wed, Jan 07, 2009 at 08:52:18PM +1100, Herbert Xu wrote:
> On Wed, Jan 07, 2009 at 07:38:59AM +0100, Willy Tarreau wrote:
> >
> > > Unfortunately, once the pipe is fed into sendpage we only use
> > > page reference counting to pin down the memory.  So as soon as
> > > sendpage returns we drop the ref count on the skb, thus freeing
> > > the memory in skb->head, which is yet to be transmitted.
> > 
> > So this means that anything relying on sendpage() is at risk ? What
> 
> No the bug is in the splice code.  sendfile() and other sendpage
> users are not affected.

but sendfile() now uses splice().

Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html