netdev - Re: [PATCH] Make possible speeds known to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49664FFD.1010608@hp.com>
Date:	Thu, 08 Jan 2009 11:11:57 -0800
From:	Rick Jones <rick.jones2@...com>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool

Jeff Garzik wrote:
> Ben Hutchings wrote:
>> The vetting of speeds is kind of silly.  Given that speed is established
>> as being a number of Mbit/s (hence the need for speed_hi), why not
>> remove the warning and the checks for known values and report it as
>> such?
> 
> 
> I'm ok with that route.  Historically it made sense, but AFAICS the 
> driver _must_ verify the speed anyway, so removing the limitation in the 
> userspace tool seems reasonable.
> 
> The next release of ethtool is coming in about 4 weeks, and we can 
> definitely get something like this in there.

I have a simple patch which does just that ready to post, but will 
point-out that removing the checks entirely will result in the speed 
being reported as 65535 (without Unknown) for an interface with its 
cable disconnected.  This however is is based only on "testing" on a 
2.6.24-22-generic (hardy) kernel with 7.3.20-k2-NAPI of the e1000 driver 
driving an Intel 82566MM (rev 03).

rick jones
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html