netdev - Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090108.113009.263402475.davem@davemloft.net>
Date:	Thu, 08 Jan 2009 11:30:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vapier.adi@...il.com
Cc:	cooloney@...nel.org, jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, graf.yang@...log.com
Subject: Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin
 MAC driver

From: "Mike Frysinger" <vapier.adi@...il.com>
Date: Thu, 8 Jan 2009 14:05:33 -0500

> On Thu, Jan 8, 2009 at 14:01, Mike Frysinger wrote:
> > On Thu, Jan 8, 2009 at 13:55, David Miller wrote:
> >> We can get VLAN packets received and sent, using AF_PACKET
> >> sockets, for example.  The chip should still respect those
> >> even if VLAN proper is not being utilized.
> >
> > any tips on doing that ?
> 
> or rather, is there a driver or you two you can point out that is
> doing this correctly ?  the ones i looked at seemed to be doing it
> like the patch we posted ...

And I disagree with how those drivers are doing it :-)

At least the programming of the chip to accept all packet
types properly, VLAN or not, regardless of kernel config,
is definitely IMHO the way to go.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html