netdev - Re: [PATCH] Make possible speeds known to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231384446.2677.32.camel@hashbaz.i.decadent.org.uk>
Date:	Thu, 08 Jan 2009 03:14:06 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Rick Jones <rick.jones2@...com>
Cc:	davem@...emloft.net, jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool

On Wed, 2009-01-07 at 18:03 -0800, Rick Jones wrote:
> Certain Broadcom 10Gb Ethernet solutions (e.g. the 57711E) can have a
> 10Gb port split into multiple virtual NICs each with an instance of
> the bnx2x driver.  These virtual NICs can be configured for any speed
> which is an integer multiple of 100 Mb/s from 100 to 10,000 Mbit/s
> inclusive.  Since this is "normal" for such systems an "Unknown!" is
> not indicated.
[...]

The vetting of speeds is kind of silly.  Given that speed is established
as being a number of Mbit/s (hence the need for speed_hi), why not
remove the warning and the checks for known values and report it as
such?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html