netdev - Re: [PATCH 5/5] Phonet: USB CDC Phonet function for gadget framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901080954.01181.remi.denis-courmont@nokia.com>
Date:	Thu, 8 Jan 2009 09:54:00 +0200
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext Marcel Holtmann" <marcel@...tmann.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] Phonet: USB CDC Phonet function for gadget framework

On Monday 29 December 2008 17:44:08 ext Marcel Holtmann, you wrote:
> > This implements the Nokia vendor-specific communication device class
> > function to exchange Phonet messages over USB. This function is already
> > found in the "PC suite" USB profile of (non-Linux) Nokia handsets.
> >
> > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
> > ---
> >  drivers/usb/gadget/f_phonet.c |  621
> > +++++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/u_phonet.h |
> >   21 ++
> >  2 files changed, 642 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/usb/gadget/f_phonet.c
> >  create mode 100644 drivers/usb/gadget/u_phonet.h
>
> any reason why you didn't add an option to Kconfig to actually select
> this gadget?

Yeah: this is NOT a gadget. This is a function for any gadget that wishes to 
use it. Same as the OBEX function in fact. What would be needed is a Kconfig 
for some gadget that actually uses that.

A -slightly outdated- example is here:
http://repository.maemo.org/pool/maemo5.0/free/k/kernel/

Regards,

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html