netdev - Re: [PATCH 0/2][RFC] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Jan 2009 19:54:12 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Anthony Liguori <anthony@...emonkey.ws>
CC:	Alex Williamson <alex.williamson@...com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	kvm <kvm@...r.kernel.org>, netdev <netdev@...r.kernel.org>,
	Mark McLoughlin <markmc@...hat.com>
Subject: Re: [PATCH 0/2][RFC] virtio_net: MAC filtering

Anthony Liguori wrote:
> Alex Williamson wrote:
>> This series builds on some of the patches Mark McLoughlin has sent out
>> recently, so likely won't apply to any current trees until those get
>> upstream.  The goal is to enable MAC filtering at the kvm/qemu level for
>> virtio-net packets.  Promiscuous and allmulti mode are handled by adding
>> bits to Mark's proposed status field.  I also add a 16 entry MAC table
>> for additional unicast and multicast addresses to filter.  If this looks
>> reasonable, I'll follow-up with VLAN filtering.
>>
>> As noted in the RFC thread adding the kvm/qemu backing, this does
>> increase the size of the virtio-net device I/O port space, up to 1kB
>> with PCI rounding if we add a 4k entry VLAN bitmap.  A 64 device limit
>> is still pretty high for a VM, but maybe we should think about adding
>> MMIO space for virtio-pci.  Thanks,
>>   
>
> I'm not quite sure the best way to address this.  Maybe another 
> control queue for sending commands to control this sort of stuff?  
> What are your thoughts Rusty?

Reducing the amount of shared state will make maintaining compatibility 
easier.  A command queue introduces asynchronity and its associated 
problems, but I think it's worthwhile.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html