netdev - Re: [PATCH] Make possible speeds known to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4966DB09.5040307@pobox.com>
Date:	Fri, 09 Jan 2009 00:05:13 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	David Miller <davem@...emloft.net>
CC:	herbert@...dor.apana.org.au, bhutchings@...arflare.com,
	rick.jones2@...com, netdev@...r.kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool

David Miller wrote:
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Date: Fri, 9 Jan 2009 15:19:53 +1100
> 
>> Jeff Garzik <jgarzik@...ox.com> wrote:
>>> For generic net stack flags outside the driver's control, that can 
>>> easily be added to ethtool_{get,set}_flags() overriding or ignoring 
>>> whatever the driver may have done.
>> To use the flags interface as is, you'd have to go through every
>> single driver to get them to call ethtool_op_set_flags.  I'm sorry
>> but I'm sticking with the current interface.
> 
> Right, the flags thing is inappropriate without major reworking for
> Herbert's GRO case and therefore his choice was completely
> appropriate.

It took about ten minutes of coding to disprove this...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html