netdev - Re: [PATCH] net: Remove redundant NAPI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090109144414.GA12445@hmsreliant.think-freely.org>
Date:	Fri, 9 Jan 2009 09:58:35 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Remove redundant NAPI functions

On Thu, Jan 08, 2009 at 08:30:10PM +0000, Ben Hutchings wrote:
> Following the removal of the unused struct net_device * parameter from
> the NAPI functions named *netif_rx_* in commit 908a7a1, they are
> exactly equivalent to the corresponding *napi_* functions and are
> therefore redundant.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> Neil Horman <nhorman@...driver.com> wrote
> re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry:
> > On Wed, Dec 17, 2008 at 07:29:36PM -0800, David Miller wrote:
> > > From: Neil Horman <nhorman@...driver.com>
> > > Date: Wed, 17 Dec 2008 20:13:06 -0500
> > > 
> > > > Ok, here you go, one omnibus patch
> > > 
> > > This doesn't apply to net-next-2.6, not even by a country mile.
> > > :-)
> > > 
> > > Please respin this, thanks.
> > 
> > 
> > Respun, and diffeed against the head of net-next-2.6.git
> > 
> > Since we migrated the napi polling infrastructure out of the net_device
> > structure, the netif_rx_[prep|schedule|complete] api has taken a net_device
> > structure pointer, which in all cases goes unused.  This patch modifies the api
> > to remove that parameter, and fixes up all the required call sites.
> [...]
> 
> I revisited this to update the out-of-tree version of the sfc driver.
> This makes the *netif_rx_* functions equivalent to the corresponding
> *napi_* functions.  So let's finish the job.  This is another search-
> and-replace, mostly compile-tested.
> 
> Ben.
> 

Makes sense to me
Acked-by: Neil Horman <nhorman@...driver.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html