netdev - Re: Some NIPQUAD_FMT -> %pI4 conversions are broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231568660.5714.23.camel@brick>
Date:	Fri, 09 Jan 2009 22:24:20 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	rdreier@...co.com, netdev@...r.kernel.org
Subject: Re: Some NIPQUAD_FMT -> %pI4 conversions are broken

On Fri, 2009-01-09 at 22:15 -0800, David Miller wrote:
> From: Harvey Harrison <harvey.harrison@...il.com>
> Date: Fri, 09 Jan 2009 22:07:25 -0800
> 
> > My apologies indeed, the best choice I think is to add a temp var
> > for now and I'll work with you to eliminate the byteswapping further
> > up the callchain so a be32 gets passed down, but that might be too
> > involved for 2.6.29.
> 
> Alternatively we could provide a %p* variant that took
> cpu endian addresses.
> 
> I don't know how useful that would be, generally.

I don't think we want that, it would be better to just start work on the
nes drivers to work directly on be32s throughout, and eject all of the
byteswapping throughout the driver.

Having such a %p helper for host-endian just encourages more drivers to
be written the same way.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html