netdev - Re: [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090109.231641.79400772.davem@davemloft.net>
Date:	Fri, 09 Jan 2009 23:16:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, Joe.Chou@....com.tw
Subject: Re: [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx
 descriptors

From: David Miller <davem@...emloft.net>
Date: Fri, 09 Jan 2009 23:07:07 -0800 (PST)

> From: Florian Fainelli <florian@...nwrt.org>
> Date: Fri, 9 Jan 2009 02:04:39 +0100
> 
> > Subject: [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx descriptors
> > 
> > This patch fixes warnings and such traces that appear when doing
> > an ifconfig down on the interface:
> > 
> > WARNING: at arch/x86/kernel/pci-dma.c:376 dma_free_coherent+0x40/0x7d()
> > Modules linked in:
> > 
> > Signed-off-by: Joe Chou <joe.chou@....com.tw>
> > Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> 
> Applied.

Actually, this breaks the build.

The problem is that there is no 'pdev' in r6040_close() where
you moved these pci_free_consistent() calls.

I guess on whatever platform you tried to compile test this,
these interfaces are macros and thus ignore the 'pdev' argument.

I'll fix this but...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html