netdev - Re: [PATCH] asix: Add support for AX88772A devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090111.001704.107600670.davem@davemloft.net>
Date:	Sun, 11 Jan 2009 00:17:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dhollis@...ehollis.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH] asix: Add support for AX88772A devices

From: David Hollis <dhollis@...ehollis.com>
Date: Sat, 10 Jan 2009 10:44:25 -0500

> @@ -878,20 +885,22 @@ static struct ethtool_ops ax88772_ethtoo
>  
>  static int ax88772_link_reset(struct usbnet *dev)
>  {
> -	u16 mode;
> -	struct ethtool_cmd ecmd;
> +	u16 mode = AX88772_MEDIUM_DEFAULT;
> +	u16 bmcr;
>  
> -	mii_check_media(&dev->mii, 1, 1);
> -	mii_ethtool_gset(&dev->mii, &ecmd);
> -	mode = AX88772_MEDIUM_DEFAULT;
> +	bmcr = asix_mdio_read(dev->net, dev->mii.phy_id, MII_BMCR);

Just out of curiosity, why did you have to change this
function to not use the generic mii_*() routines just
to support this new device variant?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html