netdev - Re: 2.6.29-rc1: Reported regressions from 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090111135237.GA20184@elte.hu>
Date:	Sun, 11 Jan 2009 14:52:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux ACPI <linux-acpi@...r.kernel.org>,
	Linux PM List <linux-pm@...ts.linux-foundation.org>,
	Linux SCSI List <linux-scsi@...r.kernel.org>
Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28


* Jaswinder Singh Rajput <jaswinderlinux@...il.com> wrote:

> On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> >
> > Regressions with patches
> > ------------------------
> >
> > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> > Subject         : Build error on latest git
> > Submitter       : Petr Titera <P.Titera@...tury.cz>
> > Date            : 2009-01-11 9:49 (1 days old)
> > References      : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> > Handled-By      : Petr Titera <P.Titera@...tury.cz>
> > Patch           : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> 
> This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP 
> is defined.
> 
> I am still in the process of cleaning non-smp data from asm/smp.h for 
> x86
> 
> Attach patch is the solution for the time being
> 
> Ingo, can you please put this in urgent queue.

yes, it already is - see below.

	Ingo

----------------->
>From 8b5a33599c541cf5bf66304343d08ff2795d038b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinder@...radead.org>
Date: Sun, 11 Jan 2009 18:38:55 +0530
Subject: [PATCH] x86: fix mpparse.c build error on latest git

Fix this by reintroducing asm/smp.h include in mpparse.c - later on
I will fix this by removing non-smp data from smp.h.

Reported-by: Petr Titera <P.Titera@...tury.cz>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/mpparse.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index c0601c2..a649a4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -27,6 +27,7 @@
 #include <asm/e820.h>
 #include <asm/trampoline.h>
 #include <asm/setup.h>
+#include <asm/smp.h>
 
 #include <mach_apic.h>
 #ifdef CONFIG_X86_32
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html