netdev - Re: [patch review 1/3] net/usb: catc.c - place dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 11 Jan 2009 13:48:37 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alexey Klimov <klimov.linux@...il.com>
Cc:	davem@...emloft.net, Greg KH <greg@...ah.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [patch review 1/3] net/usb: catc.c - place dev_err instead of err()

On Sunday 11 January 2009, Alexey Klimov wrote:
> -                               err("submit(rx_urb) status %d", res);
> +                               dev_err(&urb->dev->dev, "submit(rx_urb) status %d\n", res);

You should really find and use the device on the *interface* to which
that driver is bound, rather than the one in the URB.  That's what
gets passed in to probe(); drivers normally remember that until a
remove() callback unbinds the driver from that interface.

A weak analogy is issuing a diagnostic about the PCI bus to which
the PCI device is attached, instead of the PCI device itself.  In
both cases, the diagnostic would point to the wrong thing...

The other two patches got this right in at least some cases, but I
didn't look in any detail.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html