netdev - Re: [PATCH] net: Remove redundant NAPI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231771577.3075.5.camel@achroite>
Date:	Mon, 12 Jan 2009 14:46:17 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>, shemminger@...tta.com,
	netdev@...r.kernel.org,
	Krzysztof Hałasa <khc@...waw.pl>
Subject: Re: [PATCH] net: Remove redundant NAPI functions

On Mon, 2009-01-12 at 14:09 +0000, Ben Hutchings wrote:
> On Mon, 2009-01-12 at 07:13 +0000, Jarek Poplawski wrote:
> > On Thu, Jan 08, 2009 at 08:30:10PM +0000, Ben Hutchings wrote:
> > > Following the removal of the unused struct net_device * parameter from
> > > the NAPI functions named *netif_rx_* in commit 908a7a1, they are
> > > exactly equivalent to the corresponding *napi_* functions and are
> > > therefore redundant.
> > > 
> > > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> > > ---
> > ...
> > 
> > Alas I wasn't able to send this earlier, but here is some issue
> > (I see Krzysztof tried to patch this too):
> >
> > > diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
> > > index 2dc2416..9ea167b 100644
> > > --- a/drivers/net/wan/ixp4xx_hss.c
> > > +++ b/drivers/net/wan/ixp4xx_hss.c
> [...]
> 
> What's the issue - does it conflict with another change to this file?

Oh, now I see it - the device arguments hadn't already been removed.
Yes, I'm afraid I failed to select this driver.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html