netdev - Re: [patch v2] net/usb: remove err() messages in few drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901130940.28478.oliver@neukum.org>
Date:	Tue, 13 Jan 2009 09:40:26 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Alexey Klimov <klimov.linux@...il.com>
Cc:	dbrownell@...rs.sourceforge.net, davem@...emloft.net,
	Greg KH <greg@...ah.com>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers

Am Tuesday 13 January 2009 01:08:42 schrieb Alexey Klimov:
> @@ -675,7 +677,7 @@ static int kaweth_open(struct net_device *net)
>  
>         res = usb_autopm_get_interface(kaweth->intf);
>         if (res) {
> -               err("Interface cannot be resumed.");
> +               dev_err(&net->dev, "Interface cannot be resumed.\n");
>                 return -EIO;
>         }
>         res = kaweth_resubmit_rx_urb(kaweth, GFP_KERNEL);
> @@ -902,7 +904,7 @@ static void kaweth_async_set_rx_mode(struct kaweth_device *kaweth)
>                                 KAWETH_CONTROL_TIMEOUT);
>  
>         if(result < 0) {
> -               err("Failed to set Rx mode: %d", result);
> +               dev_err(&kaweth->dev->dev, "Failed to set Rx mode: %d\n", result);
>         }
>         else {
>                 dbg("Set Rx mode to %d", packet_filter_bitmap);
> @@ -1038,7 +1040,7 @@ static int kaweth_probe(
>                                                       "kaweth/new_code.bin",
>                                                       100,
>                                                       2)) < 0) {
> -                       err("Error downloading firmware (%d)", result);
> +                       dev_err(&intf->dev, "Error downloading firmware (%d)\n", result);

I have to veto this. You are using three different device structures
to refer to the same device. That will make it next to impossible to
find out which device originated a message.

	Regards
		Oliver