netdev - Re: [PATCH] net: Remove redundant NAPI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090112.163021.132623782.davem@davemloft.net>
Date:	Mon, 12 Jan 2009 16:30:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	khc@...waw.pl
Cc:	bhutchings@...arflare.com, jarkao2@...il.com,
	nhorman@...driver.com, shemminger@...tta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Remove redundant NAPI functions

From: Krzysztof Halasa <khc@...waw.pl>
Date: Mon, 12 Jan 2009 18:31:37 +0100

> Ben Hutchings <bhutchings@...arflare.com> writes:
> 
> >> > > --- a/drivers/net/wan/ixp4xx_hss.c
> >> > > +++ b/drivers/net/wan/ixp4xx_hss.c
> >> [...]
> >> 
> >> What's the issue - does it conflict with another change to this file?
> >
> > Oh, now I see it - the device arguments hadn't already been removed.
> > Yes, I'm afraid I failed to select this driver.
> 
> It's only possible on platforms based on IXP4xx (Intel's networking
> ARM CPU).

So, as it turns out I think I need to handle this in a few stages:

1) It doesn't build upstream in Linus's tree because of the
   dev arg, so I'll fix that upstream in net-2.6

2) Then I'll rework Ben's napi_*() patch to apply on top of that.

I can do this because I haven't published my net-next-2.6 tree
yet anywhere, so I can just rebase to fix all of this up.

Thanks.