netdev - Re: [patch v2] net/usb: remove err() messages in few drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901131025.40285.oliver@neukum.org>
Date:	Tue, 13 Jan 2009 10:25:38 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	"Alexey Klimov" <klimov.linux@...il.com>
Cc:	dbrownell@...rs.sourceforge.net, davem@...emloft.net,
	"Greg KH" <greg@...ah.com>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers

Am Tuesday 13 January 2009 09:57:12 schrieb Alexey Klimov:
> On Tue, Jan 13, 2009 at 11:40 AM, Oliver Neukum <oliver@...kum.org> wrote:

> > I have to veto this. You are using three different device structures
> > to refer to the same device. That will make it next to impossible to
> > find out which device originated a message.
> >
> Ok, i'll reformat patch. Is it okay if i use kaweth->dev->dev,
> kaweth->net->dev and intf->dev ? Or switch to kaweth->net->dev
> (instead of dev->dev)?

kaweth in kaweth_disconnect() frees the network device. Therefore
you cannot use it. You'd access freed memory. Pick one of the others
and stay with it.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html