netdev - Re: [patch v2] net/usb: remove err() messages in few drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901131207.03724.oliver@neukum.org>
Date:	Tue, 13 Jan 2009 12:07:01 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	"Alexey Klimov" <klimov.linux@...il.com>
Cc:	"David Brownell" <david-b@...bell.net>, davem@...emloft.net,
	"Greg KH" <greg@...ah.com>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers

Am Tuesday 13 January 2009 11:08:27 schrieb Alexey Klimov:
> On Tue, Jan 13, 2009 at 12:44 PM, David Brownell <david-b@...bell.net> wrote:
> > On Tuesday 13 January 2009, Oliver Neukum wrote:
> >> > Ok, i'll reformat patch. Is it okay if i use kaweth->dev->dev,
> >> > kaweth->net->dev and intf->dev ? Or switch to kaweth->net->dev
> >> > (instead of dev->dev)?
> >>
> >> kaweth in kaweth_disconnect() frees the network device. Therefore
> >> you cannot use it. You'd access freed memory. Pick one of the others
> >> and stay with it.
> >
> > intf->dev is going to be "obviously correct", the others aren't.
> >
> 
> Is this patch touch  kaweth_disconnect() ? I see dev_warn and dev_info
> there. No dev_err.

No, it does not. But you need to make sure that the devices you refer to
in debug messages are always valid. Functions that you do touch may
run after disconnect() has run. A debug message that oopses does no good.
If you cannot make sure you pass a valid device to dev_err/info don't use
them. It is as simple as that.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html