netdev - Re: [PATCH] SIS900 show warning if bogus MAC address (take 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 11:06:21 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Daniele Venzano <venza@...wnhat.org>
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org,
	venza@...wnhat.org
Subject: Re: [PATCH] SIS900 show warning if bogus MAC address (take 2)

On Tue, 13 Jan 2009 19:18:21 +0100
Daniele Venzano <venza@...wnhat.org> wrote:

> The attached patch modifies the sis900 driver when the MAC address
> read from the hardware is invalid. As suggested, the patch now
> generates a random address so that the user can go on and use
> the hardware. In any case a message is also shown to warn on the
> unexpected condition.
> This seems to happen with newer HW implementation of the sis900
> chipset, since this never came up before.
> 
> Patch is against vanilla 2.6.28 (but the driver doesn't change so often,
> so it will probably apply to older/newer versions too).
> 
> See bugzilla ID 10201 and 11649 and ignore the previous patch.
> 
> Signed-off-by: Daniele Venzano <venza@...wnhat.org>
> 
> --
> Daniele Venzano
> http://www.brownhat.org
> 

It would be good if this driver was converted from using dev_name (ie pci_name()) 
and used the standard routines which print that and more: dev_err, dev_warn, dev_dbg, etc?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html