netdev - Re: [2/2] igb: Replace LRO with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114123653.GA19257@gondor.apana.org.au>
Date:	Wed, 14 Jan 2009 23:36:53 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [2/2] igb: Replace LRO with GRO

Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
>
> Ok, a couple of things...
> First is that we should have the patch in testing (most likely today,
> do not worry dave, it won't take a week)

Thanks!

> Second is I am not sure you need to keep this code wraped in CONFIG_IGB_LRO...
> 
>  #ifdef CONFIG_IGB_LRO
> -       netdev->features |= NETIF_F_LRO;
> +       netdev->features |= NETIF_F_GRO;
>  #endif

My objective is to minimise changes with respect to the current
LRO base (the e1000e was an exception, it was the only hardware
I had :)

Therefore this patch is simply trying to replace LRO with GRO
letter by letter, so to speak.  In this case, it's preserving
the semantics of the Kconfig option, i.e., if LRO was off before,
then GRO will be off too (although it can now be enabled using
ethtool without recompiling).

> Also, you left part of the lro code in igb_receive_skb and then put in
> the GRO code.  Our preference is that you mirrored what you did with
> e1000e and just replaced the main vlan_hwacel and netif_receive_skb
> calls.

No I left in the netif_receive_skb but replaced the lro calls by
the corresponding gro calls.  Again the point is to replace LRO
exactly as it is.

Later on we can make further changes.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html