netdev - Re: [PULL -tip] fixed few make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114153825.GB32082@uranus.ravnborg.org>
Date:	Wed, 14 Jan 2009 16:38:25 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Jaswinder Singh Rajput <jaswinder@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PULL -tip] fixed few make headers_check warnings

On Wed, Jan 14, 2009 at 02:59:54PM +0530, Jaswinder Singh Rajput wrote:
> Hello Geert,
> 
> On Wed, Jan 14, 2009 at 2:26 PM, Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
> > On Tue, 13 Jan 2009, Jaswinder Singh Rajput wrote:
> >> Please pull these patches. Earlier I also floated these patches so that I can get some feedback.
> >>
> >> The following changes since commit ae2659bcd0b5bf34dd4b03f1db0a2942cc09b8e6:
> >>   Ingo Molnar (1):
> >>         Merge branch 'x86/mm'
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tiptop.git master
> >>
> >> Jaswinder Singh Rajput (7):
> >>       include of <linux/types.h> is preferred over <asm/types.h>
> >>       found __[us]{8,16,32,64} type without #include <linux/types.h>
> >>       capability.h: extern's make no sense in userspace
> >>       coda_psdev.h: extern's make no sense in userspace
> >>       in6.h: extern's make no sense in userspace
> >>       nubus.h: extern's make no sense in userspace
> >>       socket.h: extern's make no sense in userspace
> >
> > May I please remind you of my comment in
> > http://patchwork.kernel.org/patch/2093/?
> >
> 
> Thanks for your reminder :-)
> 
> > At least nubus.h still leaks forward declarations for kernel functions that
> > lack the "extern" keyword, so they still pollute user space.
> >
> 
> Yes, you are right, I just tried to pampered weeping warning messages
> which is annoying.

Hi Jaswinder.

I appreciate your work but I will like to question the approach.
We should rather take the warnings as an indication that this
file needs to be looked over and fix not only the warnings
reported but rater to fix all the questionable issues on a file-by-file basis.
If the patch gets involved then it should be split in two.

Could I ask you to at least consider this approach.

Thanks,
	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html