netdev - Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114034711.GA8361@gondor.apana.org.au>
Date:	Wed, 14 Jan 2009 14:47:11 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Yang Hongyang <yanghy@...fujitsu.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt
	with IPV6_PKTINFO option

Yang Hongyang <yanghy@...fujitsu.com> wrote:
> Actually the condition (optlen == 0) is included in (optlen < sizeof(struct in6_pktinfo)),
> so we do not need to check it separately.

You don't need to check optval == NULL either since that's the
job of copy_from_user.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html