netdev - Re: [PATCH] phylib: Fix Freescale TBI PHY detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090114.143841.153393716.davem@davemloft.net>
Date:	Wed, 14 Jan 2009 14:38:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	afleming@...escale.com
Cc:	avorontsov@...mvista.com, jgarzik@...ox.com,
	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	giulio.benetti@...ronovasrl.com
Subject: Re: [PATCH] phylib: Fix Freescale TBI PHY detection

From: Andy Fleming <afleming@...escale.com>
Date: Wed, 14 Jan 2009 12:20:35 -0600

> On Jan 14, 2009, at 9:03 AM, Anton Vorontsov wrote:
> >>
> >> There is one thing I don't actually understand though...
> >>
> >> Andy, were you testing the TBI support on a hardware where PHY ID
> >> != 0x0 or maybe your TBI PHY support patch (commit b31a1d8b41513b,
> >> dated Tue Dec 16 15:29:15 2008) was based on a bit outdated kernel
> >> version? Because according to the git timestamps, the TBI support
> >> was not working since the submission.
> >>
> >> Just in case, the hardware I'm seeing the PHY ID == 0x0 is
> >> MPC8378E-MDS.
> >
> > I think I got it. Probably the TBI support patch was based on the
> > powerpc.git next, and the commit that broke the TBI support
> > was in the net-next-2.6 tree.
> >
> > That explains why nobody noticed the issue.
> 
> 
> Yeah, I dropped the ball.  I saw the patch go in, thought that might break something, but I didn't find time to look into it.  Thanks for finding and reverting this bug.
> 
> Acked-by: Andy Fleming <afleming@...escale.com>

Patch applied, thanks everyone.

I was worried when I applied the patch causing this, that some
device would in fact trigger that specific test.  Turns out
my worries were warranted :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html