netdev - Re: [PATCHv2] smsc911x: add irq_flags in smsc911x_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114101946.GE22976@n2100.arm.linux.org.uk>
Date:	Wed, 14 Jan 2009 10:19:46 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Steve.Glendinning@...c.com
Cc:	"Stanley.Miao" <stanley.miao@...driver.com>,
	David Miller <davem@...emloft.net>,
	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCHv2] smsc911x: add irq_flags in smsc911x_platform_config.

On Wed, Jan 14, 2009 at 08:54:36AM +0000, Steve.Glendinning@...c.com wrote:
> I have two more arm platform smsc911x conversion patches (realview and 
> pcm037) which I'll post for review shortly.  Both also depend on this 
> irq_flags change, as they register their interrupts shared.  David: would 
> it make sense to put this driver patch into the arm tree?

BTW, the shared-ness of an interrupt handler depends on how the interrupt
handler is written, not on whether you require the interrupt to be
exclusively owned or not.

So, if a driver is written to co-operate properly with shared interrupts
then it should always pass IRQF_SHARED.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html