netdev - Re: [patch v2] net/usb: remove err() messages in few drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901131705.50775.david-b@pacbell.net>
Date:	Tue, 13 Jan 2009 17:05:50 -0800
From:	David Brownell <david-b@...bell.net>
To:	"Alexey Klimov" <klimov.linux@...il.com>
Cc:	"Oliver Neukum" <oliver@...kum.org>, davem@...emloft.net,
	"Greg KH" <greg@...ah.com>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers

On Tuesday 13 January 2009, Alexey Klimov wrote:
> > Use the interface passed into probe():  dev_err(&intf->dev, ...) etc
> 
> Well, in few v4l-dvb drivers successfully used &radio->usbdev->dev in
> debug messages and that doesn't look wrong.

Use intf->dev ... always.  You may need to save the interface
in probe(), but that's easy.

"Doesn't look wrong" is incorrect; it doesn't list the driver
which issued it.  Which makes it harder to track down exactly
what issued the message, and thence what it really means.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html