netdev - Re: [PATCH] smsc911x: add irq_flags in smsc911x_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1231985814.6810.15.camel@localhost>
Date:	Thu, 15 Jan 2009 10:16:54 +0800
From:	"stanley.miao" <stanley.miao@...driver.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	netdev@...r.kernel.org, steve.glendinning@...c.com,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [PATCH] smsc911x: add irq_flags in smsc911x_platform_config.

On Wed, 2009-01-14 at 17:06 +0000, Russell King - ARM Linux wrote:
> On Wed, Jan 14, 2009 at 01:21:52PM +0800, Stanley.Miao wrote:
> > When calling request IRQ it is desirable to allow platforms
> > to specific flags for the call to request_irq. Adding irq_flags
> > to smsc911x_platform_config allows these flags to be passed.
> > 
> > Signed-off-by: Stanley.Miao <stanley.miao@...driver.com>
> > ---
> >  drivers/net/smsc911x.c   |    6 ++++--
> >  include/linux/smsc911x.h |    1 +
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
> > index f513bdf..1092517 100644
> > --- a/drivers/net/smsc911x.c
> > +++ b/drivers/net/smsc911x.c
> > @@ -1896,6 +1896,7 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
> >  	unsigned int intcfg = 0;
> >  	int res_size;
> >  	int retval;
> > +	irq_flags;
> 
> This looks wrong.

Sorry, I have send the V2 version. I should send a notice to ignore this
email.

Stanley

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html