netdev - Re: Buffer allocation for USB transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <496F939B.3755.1E4CA7@ceggers.gmx.de>
Date:	Thu, 15 Jan 2009 19:50:51 +0100
From:	"Christian Eggers" <ceggers@....de>
To:	Oliver Neukum <oliver@...kum.org>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: Buffer allocation for USB transfers

Am 15 Jan 2009 um 16:43 hat Oliver Neukum geschrieben:
> Am Wednesday 14 January 2009 19:58:44 schrieb Christian Eggers:
> > At least the latter does not work on my SH-4 platform. It seems that other 
> > variables on the stack are overwritten after calling usb_control_msg(), probably as 
> > result of incorrect alignment.
> 
> Does this make it run on SH-4?
> 
> 	Regards
> 		Oliver
> 

Sorry, you have been to fast... I've already prepared a solution for this: (see attached diff)

The driver asix.c has been fixed in a similar way some time ago:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-
2.6.git;a=commitdiff;h=51bf2976b55d07f9daae9697a0a3ac9f58abcedc

I've tested this change with 2.6.17 and 2.6.23 on a SH-4. The patch should compile with 
the current version. Could you please apply this for me? I've no routine in preparing 
patches for lkml.

Thanks
Christian Eggers

Der folgende Teil dieser Nachricht enthält einen Anhang im 
sogenannten Internet MIME Nachrichtenformat.
Wenn Sie Pegasus Mail oder ein beliebiges anderes MIME-kompatibles
Email-System verwenden, sollte Sie den Anhang mit Ihrem Email-System
speichern oder anzeigen können. Anderenfalls fragen Sie Ihren Administrator.

The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any another MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

   ---- Datei Information/File information -----------
     Datei/File:  mcs7830.c.diff
     Datum/Date:  15 Jan 2009, 19:20
     Größe/Size:  1006 bytes.
     Typ/Type:    Unbekannt

Download attachment "mcs7830.c.diff" of type "Application/Octet-stream" (1006 bytes)