netdev - Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090114.210242.163189105.davem@davemloft.net>
Date:	Wed, 14 Jan 2009 21:02:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	yanghy@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt
 with IPV6_PKTINFO option

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 14 Jan 2009 15:48:56 +1100

> Yang Hongyang <yanghy@...fujitsu.com> wrote:
> >
> > If optval==NULL, what we should return?EINVAL or EFAULT?
> > If it is EINVAL,then we should check it .otherwise it's the job of 
> > copy_from_user
> 
> I think EFAULT is fine.  We return that elsewhere as well.

Actually, we return EINVAL just a few lines above this code
block for some other socket option cases when optval==NULL.

So for consistency I'm applying Yang's original patch to
net-next-2.6

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html