netdev - Re: [PATCH] Add init_dummy_netdev() and fix EMAC driver using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090114.210514.257703205.davem@davemloft.net>
Date:	Wed, 14 Jan 2009 21:05:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Geert.Uytterhoeven@...ycom.com
Cc:	benh@...nel.crashing.org, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] Add init_dummy_netdev() and fix EMAC driver using it

From: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Date: Wed, 14 Jan 2009 11:00:05 +0100 (CET)

> On Wed, 14 Jan 2009, Benjamin Herrenschmidt wrote:
> > This adds an init_dummy_netdev() function that gets a network device
> > structure (allocation and lifetime entirely under caller's control) and
> > initialize the minimum amount of fields so it can be used to schedule
> > NAPI polls without registering a full blown interface. This is to be
> > used by drivers that need to tie several hardware interfaces to a single
> > NAPI poll scheduler due to HW limitations.
> > 
> > It also updates the ibm_newemac driver to use that, this fixing the
> > oops on 2.6.29 due to passing NULL as "dev" to netif_napi_add()
> > 
> > Symbol is exported GPL only a I don't think we want binary drivers doing
> > that sort of acrobatics (if we want them at all).
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> 
> Thanks, this fixed my Sequoia!
> 
> Tested-by: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html