netdev - Re: [PATCH] smc91x: enable ethtool EEPROM interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0901160004110.9524@xanadu.home>
Date:	Fri, 16 Jan 2009 00:06:12 -0500 (EST)
From:	Nicolas Pitre <nico@....org>
To:	Vernon Sauder <vernoninhand@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] smc91x: enable ethtool EEPROM interface

On Thu, 15 Jan 2009, Vernon Sauder wrote:

> From: Vernon Sauder <vsauder@...and.com>
> 
> 
> Signed-off-by: Vernon Sauder <vsauder@...and.com>
> ---
>  drivers/net/smc91x.c |  112 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 110 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
> index b215a8d..f692439 100644
> --- a/drivers/net/smc91x.c
> +++ b/drivers/net/smc91x.c
> @@ -1643,6 +1643,113 @@ static void smc_ethtool_setmsglevel(struct net_device *dev, u32 level)
>  	lp->msg_enable = level;
>  }
>  
> +/* GP is same as RPC, just bank 1 */
> +#define SMC_GET_GP		SMC_GET_RPC
> +#define SMC_SET_GP		SMC_SET_RPC

NAK.  This will blow up the moment you have SMC_DEBUG > 0.
Please add proper definitions in smc91x.h instead.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html