netdev - Re: [PATCH] PS3: gelic: convert to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090116160550.0B62.40F06B3A@sm.sony.co.jp>
Date:	Fri, 16 Jan 2009 16:09:53 +0900
From:	Masakazu Mokuno <mokuno@...sony.co.jp>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org,
	Geoff Levand <geoffrey.levand@...sony.com>
Subject: Re: [PATCH] PS3: gelic: convert to net_device_ops


On Thu, 15 Jan 2009 22:07:08 -0800
Stephen Hemminger <shemminger@...tta.com> wrote:

> On Fri, 16 Jan 2009 13:57:15 +0900
> Masakazu Mokuno <mokuno@...sony.co.jp> wrote:
> 
> > Convert the gelic driver to net_device_ops
> > 
> > Signed-off-by: Masakazu Mokuno <mokuno@...sony.co.jp>
> > ---
> >  drivers/net/ps3_gelic_net.c |   23 +++++++++++++----------
> >  1 file changed, 13 insertions(+), 10 deletions(-)
> > 
> > --- a/drivers/net/ps3_gelic_net.c
> > +++ b/drivers/net/ps3_gelic_net.c
> > @@ -1403,6 +1403,18 @@ void gelic_net_tx_timeout(struct net_dev
> >  		atomic_dec(&card->tx_timeout_task_counter);
> >  }
> >  
> > +static const struct net_device_ops gelic_netdevice_ops = {
> > +	.ndo_open = gelic_net_open,
> > +	.ndo_stop = gelic_net_stop,
> > +	.ndo_start_xmit = gelic_net_xmit,
> > +	.ndo_set_multicast_list = gelic_net_set_multi,
> > +	.ndo_change_mtu = gelic_net_change_mtu,
> > +	.ndo_tx_timeout = gelic_net_tx_timeout,
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +	.ndo_poll_controller = gelic_net_poll_controller,
> > +#endif
> >
> 
> You probably want to add:
> 	.ndo_change_mtu		= eth_change_mtu,
> 	.ndo_set_mac_address 	= eth_mac_addr,
> 	.ndo_validate_addr	= eth_validate_addr,

Thanks!

I'll respin.

-- 
Masakazu Mokuno

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html