netdev - RE: [PATCH 2/2] netxen: include ipv6.h (fixes build failure)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9FB481EF4C70734186A21A64437F637C02A100BB7F@nxexch.unminc.com>
Date:	Fri, 16 Jan 2009 11:21:24 -0800
From:	Dhananjay Phadke <dhananjay@...xen.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>
Subject: RE: [PATCH 2/2] netxen: include ipv6.h (fixes build failure)

My bad, I copy-pasted the --to --cc list to git command line and missed out the original Sender in that email.

Double apologies to Ingo, first for introducing the build error and other for fixing without credit to reporter :-(.

Thanks Ingo, Dave.

-Dhananjay

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net]
Sent: Friday, January 16, 2009 11:05
To: Dhananjay Phadke
Cc: netdev@...r.kernel.org; akpm@...ux-foundation.org; linux-kernel@...r.kernel.org; mingo@...e.hu
Subject: Re: [PATCH 2/2] netxen: include ipv6.h (fixes build failure)

From: Dhananjay Phadke <dhananjay@...xen.com>
Date: Fri, 16 Jan 2009 10:28:04 -0800

> Fixes a build error in absence of CONFIG_IPV6:
>
> drivers/net/netxen/netxen_nic_main.c:1189: error: implicit declaration of function 'ipv6_hdr'
> drivers/net/netxen/netxen_nic_main.c:1189: error: invalid type argument of '->'
>
> Signed-off-by: Dhananjay Phadke <dhananjay@...xen.com>

Gee, thanks for not even mentioning Ingo having reported this problem
in your commit message. :-((

I've fixed this when committing.

You didn't even CC: him on this patch posting, what gives?

No virus found in this incoming message.
Checked by AVG.
Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18

No virus found in this outgoing message.
Checked by AVG.
Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html