netdev - Re: [PATCH 5/5] arm: convert omap ldp platform to use smsc911x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090119223541.GK18301@n2100.arm.linux.org.uk>
Date:	Mon, 19 Jan 2009 22:35:41 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Steve Glendinning <steve.glendinning@...c.com>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Stanley Miao <stanley.miao@...driver.com>,
	Ian Saturley <ian.saturley@...c.com>
Subject: Re: [PATCH 5/5] arm: convert omap ldp platform to use smsc911x

On Thu, Jan 15, 2009 at 09:08:02AM +0000, Steve Glendinning wrote:
> -	ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
> -	ldp_smc911x_resources[0].end   = cs_mem_base + 0xf;
> +	ldp_smsc911x_resources[0].start = cs_mem_base + 0x0;
> +	ldp_smsc911x_resources[0].end   = cs_mem_base + 0xf;

Actually, having finally got around to checking whether the smc911x
support submitted from the OMAP folk on the LDP board works, I find
it doesn't.

And the reason it doesn't is that SMC911x wants to claim 256 bytes
of space in this resource.  With only 16 bytes in the parent resource,
that isn't going to work.

It looks to me like this is wrong for the SMSC911x driver as well.

davem - I can see if I merge a fix for this (once I have confirmation
what the fix should be) and push it for -rc, that will make things a
little more complicated at your end.  Suggest we hold fire on these
patches for a few more days.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html