[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090118.214025.262576583.davem@davemloft.net>
Date: Sun, 18 Jan 2009 21:40:25 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: gerrit@....abdn.ac.uk
Cc: dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] dccp: Initialisation and type-checking of feature
sysctls
From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sat, 17 Jan 2009 10:36:32 +0100
> This patch takes care of initialising and type-checking sysctls related to
> feature negotiation. Type checking is important since some of the sysctls
> now directly impact the feature-negotiation process.
>
> The sysctls are initialised with the known default values for each feature.
> For the type-checking the value constraints from RFC 4340 are used:
>
> * Sequence Window uses the specified Wmin=32, the maximum is ulong (4 bytes),
> tested and confirmed that it works up to 4294967295 - for Gbps speed;
> * Ack Ratio is between 0 .. 0xffff (2-byte unsigned integer);
> * CCIDs are between 0 .. 255;
> * request_retries, retries1, retries2 also between 0..255 for good measure;
> * tx_qlen is checked to be non-negative;
> * sync_ratelimit remains as before.
...
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>
> Acked-by: Ian McDonald <ian.mcdonald@...di.co.nz>
Applied for 2.6.30
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists