netdev - Re: [PATCH] mac80211: cleanup kmalloc/memset -> kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090118.214335.142183946.davem@davemloft.net>
Date:	Sun, 18 Jan 2009 21:43:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	linville@...driver.com
Subject: Re: [PATCH] mac80211: cleanup kmalloc/memset -> kcalloc

From: Wei Yongjun <yjwei@...fujitsu.com>
Date: Thu, 15 Jan 2009 17:41:16 +0800

> Transform calls kmalloc/memset to a single kcalloc.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

Wireless, thus this goes to linux-wireless and John
Linville, CC:'d

> diff --git a/net/mac80211/ht.c b/net/mac80211/ht.c
> index 5f510a1..743d530 100644
> --- a/net/mac80211/ht.c
> +++ b/net/mac80211/ht.c
> @@ -949,7 +949,7 @@ void ieee80211_process_addba_request(struct ieee80211_local *local,
>  
>  	/* prepare reordering buffer */
>  	tid_agg_rx->reorder_buf =
> -		kmalloc(buf_size * sizeof(struct sk_buff *), GFP_ATOMIC);
> +		kcalloc(buf_size, sizeof(struct sk_buff *), GFP_ATOMIC);
>  	if (!tid_agg_rx->reorder_buf) {
>  #ifdef CONFIG_MAC80211_HT_DEBUG
>  		if (net_ratelimit())
> @@ -959,8 +959,6 @@ void ieee80211_process_addba_request(struct ieee80211_local *local,
>  		kfree(sta->ampdu_mlme.tid_rx[tid]);
>  		goto end;
>  	}
> -	memset(tid_agg_rx->reorder_buf, 0,
> -		buf_size * sizeof(struct sk_buff *));
>  
>  	if (local->ops->ampdu_action)
>  		ret = local->ops->ampdu_action(hw, IEEE80211_AMPDU_RX_START,
> -- 
> 1.6.0.3
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html