netdev - Re: [PATCH] e1000e: drop lltx, remove unnecessary lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Jan 2009 16:52:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	donash4@...il.com
Subject: Re: [PATCH] e1000e: drop lltx, remove unnecessary lock

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 19 Jan 2009 16:17:08 -0800

> LLTX is deprecated and complicated, don't use it.  It was observed by Don Ash
> <donash4@...il.com> that e1000e was acquiring this lock in the NAPI cleanup
> path.  This is obviously a bug, as this is a leftover from when e1000
> supported multiple tx queues and fake netdevs.
> 
> another user reported this to us and tested routing with the 2.6.27 kernel and
> this patch and reported a 3.5 % improvement in packets forwarded in a
> multi-port test on 82571 parts.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Nice, applied.

One down, 16 to go.  The following drivers are on notice :-)

drivers/net/atl1e/atl1e_main.c
drivers/net/bonding/bond_main.c
drivers/net/chelsio/cxgb2.c
drivers/net/cris/eth_v10.c
drivers/net/cxgb3/cxgb3_main.c
drivers/net/e1000/e1000_main.c
drivers/net/ehea/ehea_main.c
drivers/net/ibmveth.c
drivers/net/igb/igb_main.c
drivers/net/loopback.c
drivers/net/pasemi_mac.c
drivers/net/rionet.c
drivers/net/spider_net.c
drivers/net/sungem.c
drivers/net/tehuti.c
drivers/net/veth.c
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html