netdev - Re: [net-2.6] tg3: Fix firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090119.165756.163650913.davem@davemloft.net>
Date:	Mon, 19 Jan 2009 16:57:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com, andy@...yhouse.net
Subject: Re: [net-2.6] tg3: Fix firmware loading

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Mon, 19 Jan 2009 05:17:32 -0800

> This patch modifies how the tg3 driver handles device firmware.
> 
> The patch starts by consolidating David Woodhouse's earlier patch under
> the same name.  Specifically, the patch moves the request_firmware call
> into a separate tg3_request_firmware() function and calls that function
> from tg3_open() rather than tg3_init_one().
> 
> The patch then goes on to limit the number of devices that will make
> request_firmware calls.  The original firmware patch unnecessarily
> requested TSO firmware for devices that did not need it.  This patch
> reduces the set of devices making TSO firmware patches to approximately
> the following device set : 5703, 5704, and 5705.
> 
> Finally, the patch reduces the effects of a request_firmware() failure.
> For those devices that are requesting TSO firmware, the driver will turn
> off the TSO capability.  If TSO firmware becomes available at a later
> time, the device can be closed and then opened again to reacquire the
> TSO capability.
> 
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html