netdev - Re: [PATCH] phylib: unsigneds go unnoticed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090119.171432.155456999.davem@davemloft.net>
Date:	Mon, 19 Jan 2009 17:14:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	paulius.zaleckas@...tonika.lt, netdev@...r.kernel.org
Subject: Re: [PATCH] phylib: unsigneds go unnoticed

From: Roel Kluin <roel.kluin@...il.com>
Date: Mon, 19 Jan 2009 10:41:58 +0100

> David Miller wrote:
> > From: Roel Kluin <roel.kluin@...il.com>
> > Date: Sun, 18 Jan 2009 23:57:43 +0100
> > 
> >> both pdata->mdc and pdata->mdio are unsigned. Notice a negative
> >> return value.
> > 
> > You left the unsigned tests in there:
> > 
> >>  	if (pdata->mdc < 0 || pdata->mdio < 0)
> >>  		goto out_free;
> > 
> > Please remove them.
> 
> thanks, here it is, also with a signoff:
> 
> both pdata->mdc and pdata->mdio are unsigned. Notice a negative
> return value.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Applied, thanks Roel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html