netdev - Re: [PATCH] mv643xx_eth: fix multicast filter programming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090119.171724.169700515.davem@davemloft.net>
Date:	Mon, 19 Jan 2009 17:17:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	tbm@...ius.com, pacman@...h.dhis.org, netdev@...r.kernel.org,
	matt@...esi-usa.com, paubert@...m.es
Subject: Re: [PATCH] mv643xx_eth: fix multicast filter programming

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Mon, 19 Jan 2009 10:58:13 +0100

> Commit 66e63ffbc04706568d8789cbb00eaa8ddbcae648 ("mv643xx_eth:
> implement ->set_rx_mode()") cleaned up mv643xx_eth's multicast filter
> programming, but broke it as well.
> 
> The non-special multicast filter table (for multicast addresses that
> are not of the form 01:00:5e:00:00:xx) consists of 256 hash table
> buckets organised as 64 32-bit words, where the 'accept' bits are
> in the LSB of each byte, so in bits 24 16 8 0 of each 32-bit word.
> The old code got this right, but the referenced commit broke this by
> using bits 3 2 1 0 instead.  This commit fixes this up.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html