netdev - Re: cxgb3: Replace LRO with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090119.180330.255801668.davem@davemloft.net>
Date:	Mon, 19 Jan 2009 18:03:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	divy@...lsio.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	swise@...ngridcomputing.com
Subject: Re: cxgb3: Replace LRO with GRO

From: David Miller <davem@...emloft.net>
Date: Mon, 19 Jan 2009 17:03:08 -0800 (PST)

> From: Divy Le Ray <divy@...lsio.com>
> Date: Thu, 15 Jan 2009 13:14:03 -0800
> 
> > cxgb3: Replace LRO with GRO
> > 
> > This patch makes cxgb3 invoke the GRO hooks instead of LRO.  As
> > GRO has a compatible external interface to LRO this is a very
> > straightforward replacement.
> > 
> > I've kept the ioctl controls for per-queue LRO switches.  However,
> > we should not encourage anyone to use these.
> > 
> > Because of that, I've also kept the skb construction code in
> > cxgb3.  Hopefully we can phase out those per-queue switches
> > and then kill this too.
> > 
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > Acked-by: Divy Le Ray <divy@...lsio.com>
> 
> I've added this to my net-next-2.6 tree.
> 
> I'm confident that you will work out the performance issues
> with Herbert, else we'll simply revert this.

I had to add a fix due to some build bustage resulting from
this change.

drivers/scsi/cxgb3i/cxgb3i_ddp.h was depending upon the implicit
inclusion of linux/vmalloc.h coming from the inet_lro.h include
which is removed by this change.

In file included from drivers/scsi/cxgb3i/cxgb3i_ddp.c:24:
drivers/scsi/cxgb3i/cxgb3i_ddp.h: In function 'cxgb3i_alloc_big_mem':
drivers/scsi/cxgb3i/cxgb3i_ddp.h:148: error: implicit declaration of function 'vmalloc'
drivers/scsi/cxgb3i/cxgb3i_ddp.h:148: warning: assignment makes pointer from integer without a cast
drivers/scsi/cxgb3i/cxgb3i_ddp.h: In function 'cxgb3i_free_big_mem':
drivers/scsi/cxgb3i/cxgb3i_ddp.h:157: error: implicit declaration of function 'vfree'

I'll fix this up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html