netdev - Re: why usr/include/linux/if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901201847.03030.arnd@arndb.de>
Date:	Tue, 20 Jan 2009 18:47:01 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	mike.mclagan@...ux.org, Ingo Molnar <mingo@...e.hu>,
	Sam Ravnborg <sam@...nborg.org>, netdev@...r.kernel.org,
	davem@...emloft.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: why usr/include/linux/if_frad.h is required

On Tuesday 20 January 2009, Jaswinder Singh Rajput wrote:
> CC: LKML
> 
> On Tue, 2009-01-20 at 20:23 +0530, Jaswinder Singh Rajput wrote:
> > For if_frad.h I am getting two warnings with 'make headers_check':
> >   usr/include/linux/if_frad.h:29: leaks CONFIG_DLCI to userspace where it is not valid
> >   usr/include/linux/if_frad.h:129: leaks CONFIG_DLCI to userspace where it is not valid
> > 
> > Almost all if_frad.h is covered with #if defined(CONFIG_DLCI) || defined(CONFIG_DLCI_MODULE) 
> > 
> > If I remove this portion so only this what we get in userspace:
> > 
> > #ifndef _FRAD_H_
> > #define _FRAD_H_
> > 
> > #include <linux/if.h>
> > 
> > #endif
> > 
> > So I am surprising what is the point of this ? 
> > 
> > Can I change its name to is_fraud ;-)

The CONFIG_DLCI check in there is clearly in error, the definition in there
is a user interface. The obvious solution is to drop the #if / #endif pair
without a replacement.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html