netdev - Re: Fwd: iproute2 wrong burst/cburst calculation?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2009 09:48:43 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Denys Fedoryschenko <denys@...p.net.lb>
Cc:	netdev@...r.kernel.org, Stephen Hemminger <shemminger@...tta.com>
Subject: Re: Fwd: iproute2 wrong burst/cburst calculation?

On Tue, Jan 20, 2009 at 10:57:11PM +0200, Denys Fedoryschenko wrote:
...
> class htb 1:3 parent 1:2 leaf 3: prio 0 quantum 200000 rate 680000Kbit ceil 
> 950000Kbit burst 1445b/8 mpu 0b overhead 0b cburst 1425b/8 mpu 0b overhead 0b 
> level 0
>  Sent 140533370 bytes 200327 pkt (dropped 0, overlimits 0 requeues 0)
>  rate 52228Kbit 9289pps backlog 0b 0p requeues 0
>  lended: 199720 borrowed: 607 giants: 0
>  tokens: 17 ctokens: 12
> 
> So just look: 1:3 have burst 1445 / 1425, and 1:2, his parent - burst 1425 and 
> cburst 1425. It is wrong? I am not so experienced in htb to judge, but i feel 
> like iproute2 calculating burst/cburst not right way. 
...
> I guess it was supposed in this formula, that size must vary, and higher rate 
> must have higher size. But because our timer resolution so high, and we add 
> also mtu value... things going wrong.
> I dont know yet, how to calculate this correctly. Even not sure if it is 
> wrong. But HTB author, stated clearly 

Denys, I can't verify this all anytime soon, but most likely you are
right. Lower burst/cburst for higher rates means there have to be some
overflow, but since I think you know tc better than me, probably a
patch is needed. (Then one of possible "fast" fixes could be probably
to check for some max rate which doesn't overflow yet.)

Thanks,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html