netdev - Re: [PATCH 9/9] bnx2x: annotate nvram dword reading/writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Jan 2009 22:57:22 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
cc:	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 9/9] bnx2x: annotate nvram dword reading/writing

On Thu, 2009-01-22 at 10:18 -0800, Harvey Harrison wrote:
> On Thu, 2009-01-22 at 19:50 +0200, Eilon Greenstein wrote:
> > On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> > > I believe this exposed an endian bug as the shifting of
> > > bytes from the data buffer was done in cpu-order, then
> > > masked into a be32 and the combined value was then converted
> > > to cpu-order, this does all the masking in be-byteorder and
> > > passes a cpu-ordered value to the write routine.
> > > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > 
> > This change is breaking the FW upgrade utility which uses this interface
> > since it is changing the content. I will need to work with the engineer
> > that owns this utility, but this change will probably stay out for a
> > while
> > 
> 
> No worries, can you explain briefly what the code is trying to accomplish?
> Maybe it was written assuming a le-machine, because this is going to
> work differently on a be-machine.
> 
> Harvey

The utility simply works with the current implementation (on both be and
le) and this is why changing the logic breaks it. I will look into it to
see if we can change the utility logic as well (maybe according to the
driver version) - it is not that easy since this utility supports other
drivers as well.

Harvey - thanks again for this patch, it is definitely a step in the
right direction.

Eilon


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html