netdev - Re: [PATCH] sctp/ipv6.c: use ipv6_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4978E2B3.3010109@hp.com>
Date:	Thu, 22 Jan 2009 16:18:43 -0500
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Joe Perches <joe@...ches.com>
CC:	Sridhar Samudrala <sri@...ibm.com>,
	Networking Team <netdev@...r.kernel.org>,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH] sctp/ipv6.c: use ipv6_addr_copy

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index ceaa4aa..7862275 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -97,8 +97,7 @@ static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
>  		if (addr) {
>  			addr->a.v6.sin6_family = AF_INET6;
>  			addr->a.v6.sin6_port = 0;
> -			memcpy(&addr->a.v6.sin6_addr, &ifa->addr,
> -				 sizeof(struct in6_addr));
> +			ipv6_addr_copy(&addr->a.v6.sin6_addr, &ifa->addr);
>  			addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex;
>  			addr->valid = 1;
>  			spin_lock_bh(&sctp_local_addr_lock);
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

ACK.  Simple enough of a cleanup.

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html