netdev - Re: [PATCH] Fix missing ifdef in isdn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <154e089b0901230144o2b52c232kb93a71429fb258a9@mail.gmail.com>
Date:	Fri, 23 Jan 2009 10:44:11 +0100
From:	Hannes Eder <hannes@...neseder.net>
To:	Karsten Keil <kkeil@...e.de>
Cc:	Daniele Venzano <venza@...wnhat.org>,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] Fix missing ifdef in isdn_ppp

Add CC. I think this could go upstream via David Miller's net-2.6 tree.

Best,
Hannes

On Thu, Jan 22, 2009 at 11:18 PM, Karsten Keil <kkeil@...e.de> wrote:
> The following patch fixes a warning caused by a missing ifdef in
> isdn_ppp.c. A function was defined, but never used if CONFIG_IPPP_FILTER
> was not defined.
>
> The warning was: 'get_filter' defined but not used
> Patch is against 2.6.28.1
>
> Signed-off-by: Daniele Venzano <venza@...wnhat.org>
> Acked-by: Karsten Keil <kkeil@...e.de>
>
> --- a/drivers/isdn/i4l/isdn_ppp.c       2009-01-22 15:01:27.000000000 +0100
> +++ b/drivers/isdn/i4l/isdn_ppp.c       2009-01-22 15:01:59.000000000 +0100
> @@ -431,6 +431,7 @@ set_arg(void __user *b, void *val,int le
>        return 0;
>  }
>
> +#ifdef CONFIG_IPPP_FILTER
>  static int get_filter(void __user *arg, struct sock_filter **p)
>  {
>        struct sock_fprog uprog;
> @@ -465,6 +466,7 @@ static int get_filter(void __user *arg,
>        *p = code;
>        return uprog.len;
>  }
> +#endif /* CONFIG_IPPP_FILTER */
>
>  /*
>  * ippp device ioctl
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html